Skip to content

Feat/remove welcome message and unused commands#64

Open
Santiago-j-s wants to merge 15 commits intomainfrom
feat/remove-welcome-message-and-unused-commands
Open

Feat/remove welcome message and unused commands#64
Santiago-j-s wants to merge 15 commits intomainfrom
feat/remove-welcome-message-and-unused-commands

Conversation

@Santiago-j-s
Copy link
Collaborator

@Santiago-j-s Santiago-j-s commented May 24, 2025

Stacks over #63

Improve Type Safety and Code Quality

Changes

  • Enhanced type safety by adding TextChannel type casting for interaction.channel usage across commands
  • Removed unused poll command and related EMOJI_NUMBERS constants to reduce code bloat
  • Strengthened type definitions by replacing any with unknown and making DiscordEvent generic
  • Added runtime validation in interaction handler to ensure commands have proper execute functions
  • Improved API response typing with proper type assertions for mentorship and warning endpoints

Technical Details

  • Added TODO comments for future channel type validation improvements
  • Updated Discord.js module declarations for better type inference
  • Enhanced error handling in command execution flow
  • This PR focuses on making the codebase more maintainable and type-safe without introducing breaking changes to functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant